arturobernalg commented on code in PR #452:
URL:
https://github.com/apache/httpcomponents-client/pull/452#discussion_r1215666911
##########
httpclient/src/main/java/org/apache/http/impl/conn/Wire.java:
##########
@@ -84,7 +84,9 @@ private void wire(final String header, final InputStream
inStream)
buffer.append('\"');
buffer.insert(0, '\"');
buffer.insert(0, header);
- log.debug(id + " " + buffer.toString());
+ if(enabled()) {
Review Comment:
1. The change you've made seems to be relatively minor and mostly involves
adding a new debug logging statement. I'm unsure if making such a small change
warrants a new version (4.5). In fact the new version use slf4j
2. This pull request seems to focus solely on one specific change, but it's
important to consider the broader context. For instance, how does this change
affect the code at line 72? A comprehensive review should take into account all
the areas of the codebase that could potentially be affected by the
modification.
3. Lastly, it's crucial to note that the Apache Commons Logging library's
Log interface, which we're using here, does not include a debug(String, String,
String) method. The debug method you've used in your logging statement,
log.debug("{} {}", id, buffer.toString());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
