arturobernalg commented on PR #446: URL: https://github.com/apache/httpcomponents-client/pull/446#issuecomment-1546745527
> @arturobernalg > > 1. While reviewing your code I realized that `CacheControlHeaderParser` in its present form was wrong. It assumes that there can be only a single header `Cache-Control` header, which is wrong. There can be multiple headers, all of which must be parsed and taken into account. > > Headers > > ``` > Cache-Control: this, that > ``` > > and > > ``` > Cache-Control: this > Cache-Control: that > ``` > > must be treated as equivalent and must produce the same `Cache-Control` structure. I also would like the parser to be able to parse `Cache-Control` with values in one pass with a single cursor. > > 2. I found out that `Cache-Control` get parsed over and over again multiple times in the course of a request execution. This is wasteful and conceptually wrong. > > I am going to address these two issues, once your PR is merged. @ok2c , you're right. I didn't realize that. My apologies. I have made the necessary changes to resolve the issue. After merging the HTTPCLIENT-2273 PR, I will update the branch and fix the conflict. You can find the PR here: https://github.com/apache/httpcomponents-client/pull/447. Regarding point 2, I would also like to address it, but I need some guidance or instructions to proceed." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
