[
https://issues.apache.org/jira/browse/HTTPASYNC-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503636#comment-17503636
]
Fernando Soares Carnevale Ito commented on HTTPASYNC-168:
---------------------------------------------------------
The change was introduced here in this revision
Revision: 1838035
Author: ggregory
Date: Tuesday, August 14, 2018 1:57:56 PM
Message:
Use camel-case; don't nest unnecessarily.
>From the content of this change, I just assumed that it was unintentional
>since there is a renaming of the variable iosession to ioSession
Maybe the intention was to align the naming pattern with JVM properties
http.keepAlive and http.maxConnections
If it was the latter, would it be possible to maybe modify its use to check
first for "http.ioSession-factory-registry" and if not present, check for
"http.iosession-factory-registry"? So it would work for both newer users while
keeping compatibility with older users
> Renamed property key breaks Apache CXF
> --------------------------------------
>
> Key: HTTPASYNC-168
> URL: https://issues.apache.org/jira/browse/HTTPASYNC-168
> Project: HttpComponents HttpAsyncClient
> Issue Type: Bug
> Affects Versions: 4.1.5
> Reporter: Fernando Soares Carnevale Ito
> Priority: Major
>
> The value of property
> IOSESSION_FACTORY_REGISTRY defined in the class
> PoolingNHttpClientConnectionManager was rename from
> "http.iosession-factory-registry" to
> "http.ioSession-factory-registry"
>
> I realize that this property is not public but, for example, APACHE CXF uses
> it and other projects might be using it too.
>
> I believe that this property was renamed by accident and this issue is to
> check whether it is possible to revert this rename
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
