[ https://issues.apache.org/jira/browse/HTTPCLIENT-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000770#comment-17000770 ]
ASF subversion and git services commented on HTTPCLIENT-2040: ------------------------------------------------------------- Commit fa1a8d240bb3283cbbd1d7b12c0c868a67d3fa3a in httpcomponents-client's branch refs/heads/HTTPCLIENT-2040 from Oleg Kalnichevski [ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=fa1a8d2 ] HTTPCLIENT-2040: Copy headers from the original request to the redirect request > Headers are not sent when following redirects > --------------------------------------------- > > Key: HTTPCLIENT-2040 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2040 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient (classic) > Affects Versions: 5.0 Beta6 > Reporter: Jeff Schnitzer > Priority: Major > > It appears that headers are not sent when following redirects. > RedirectExec.execute() contains this code: > > {{ switch (statusCode) { > case HttpStatus.SC_MOVED_PERMANENTLY: > case HttpStatus.SC_MOVED_TEMPORARILY: > case HttpStatus.SC_SEE_OTHER: > if (!Methods.isSafe(request.getMethod())) { > final HttpGet httpGet = new > HttpGet(redirectUri); > > httpGet.setHeaders(originalRequest.getHeaders()); > redirect = httpGet; > } else { > redirect = null; > } > } > if (redirect == null) { > redirect = new > BasicClassicHttpRequest(originalRequest.getMethod(), redirectUri); > redirect.setEntity(originalRequest.getEntity()); > } > }} > If the method is not 'safe' and converted to a GET, headers get copied from > the original request. Otherwise, the original headers are silently dropped. > Desired behavior: Headers should always be copied from the original request. > That was the behavior of HttpClient 4.x. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org