ok2c commented on a change in pull request #149: Information responses (1xx) 
processing implemented.
URL: 
https://github.com/apache/httpcomponents-client/pull/149#discussion_r287838269
 
 

 ##########
 File path: 
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/DefaultAsyncCacheRevalidator.java
 ##########
 @@ -130,6 +130,12 @@ public AsyncDataConsumer handleResponse(
                                     return 
asyncExecCallback.handleResponse(response, entityDetails);
                                 }
 
+                                @Override
+                                public void handleInformationResponse(final 
HttpResponse response) throws HttpException, IOException {
+                                    responseRef.set(response);
 
 Review comment:
   @kirill-usov Are you sure this is the right thing to do here? Should 
informational response have any impact on cache re-validation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to