[
https://issues.apache.org/jira/browse/HTTPCLIENT-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358166#comment-16358166
]
ASF GitHub Bot commented on HTTPCLIENT-1904:
--------------------------------------------
GitHub user navajo72 opened a pull request:
https://github.com/apache/httpcomponents-client/pull/98
HTTPCLIENT-1904: check cookie domain for null
Ok, second try. Now it seems to be correct.
The fix matches the behaviour of the BasicDomainHandler.
Hans-Peter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navajo72/httpcomponents-client HTTPCLIENT-1904
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-client/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit c215bc7bb5f1aae9387c420c5b668ec3c5830b05
Author: Hans-Peter Keck <hans-peter.keck@...>
Date: 2018-02-09T09:21:59Z
HTTPCLIENT-1904: check cookie domain for null
----
> NPE in PublicSuffixDomainFilter
> -------------------------------
>
> Key: HTTPCLIENT-1904
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1904
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.5.5
> Reporter: Hans-Peter Keck
> Priority: Minor
>
> The PublicSuffixDomainFilter.match(...) will throw an NPE if called with a
> cookie that has no domain set (i.e. it is null). The filter should handle
> this case gracefully, which means to just return "false".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
