[ 
https://issues.apache.org/jira/browse/HBASE-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-18554.
-------------------------------
    Hadoop Flags: Reviewed
    Release Note: Marked the current Append.add method as deprecated since it 
misses the 'throws IOException' declaration. In 3.0.0, we will throw an 
UncheckedIOException, and in 4.0.0 we will change the method signature.
      Resolution: Fixed

Pushed to master and branch-3.

Thanks [~nihaljain.cs] for reviewing!

> Append#add doesn't check the row of passed cell
> -----------------------------------------------
>
>                 Key: HBASE-18554
>                 URL: https://issues.apache.org/jira/browse/HBASE-18554
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: beginner, pull-request-available
>             Fix For: 3.0.0-beta-2
>
>         Attachments: HBASE-18554.master.001.patch, 
> HBASE-18554.master.002.patch
>
>
> {code}
>   @SuppressWarnings("unchecked")
>   public Append add(final Cell cell) {
>     // Presume it is KeyValue for now.
>     byte [] family = CellUtil.cloneFamily(cell);
>     List<Cell> list = this.familyMap.get(family);
>     if (list == null) {
>       list  = new ArrayList<>(1);
>     }
>     // find where the new entry should be placed in the List
>     list.add(cell);
>     this.familyMap.put(family, list);
>     return this;
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to