sschiffli commented on code in PR #1155:
URL: https://github.com/apache/guacamole-client/pull/1155#discussion_r2818504287
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -926,6 +987,39 @@ Guacamole.Keyboard = function Keyboard(element) {
};
+ /**
+ * Handles a mouse event to resolve deferred Meta key events. When a Meta
+ * key is pressed, it is deferred to determine if it's being used as a
+ * modifier or as a standalone key. A mouse click with Meta held provides
+ * the context needed to resolve this, enabling Cmd+Click functionality.
+ *
+ * @param {Guacamole.Mouse.Event} mouseEvent
+ * The mouse event that occurred.
+ */
+ this.handleMouseEvent = function(mouseEvent) {
Review Comment:
Yeah I struggled with this naming. There are already `syncModifierStates`
and `updateModifierState` in this file, so maybe `updateModifiersFromMouse` is
a good canidate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
