mike-jumper commented on code in PR #262:
URL: https://github.com/apache/guacamole-manual/pull/262#discussion_r2006091157
##########
.github/workflows/pr-build.yml:
##########
@@ -26,4 +26,16 @@ jobs:
- name: Build Docker container
shell: sh
run: |
- docker build --pull --no-cache --force-rm .
+ docker build --pull --no-cache --tag built-manual-image .
+ docker create --name built-manual-container built-manual-image
+ docker cp built-manual-container:/usr/local/apache2/htdocs
"$RUNNER_TEMP/htdocs"
+ docker container rm --force --volumes built-manual-container
+ docker image rm --force built-manual-image
Review Comment:
Just occurred to me that this will be a race condition if multiple PR builds
end up getting assigned to the same runner. Maybe the container name and image
should be unique for the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
