corentin-soriano commented on code in PR #559:
URL: https://github.com/apache/guacamole-server/pull/559#discussion_r1827573053
##########
src/protocols/rdp/settings.c:
##########
@@ -1960,7 +1982,29 @@ void guac_rdp_push_settings(guac_client* client,
rdp_settings->GatewayDomain =
guac_strdup(guac_settings->gateway_domain);
rdp_settings->GatewayUsername =
guac_strdup(guac_settings->gateway_username);
rdp_settings->GatewayPassword =
guac_strdup(guac_settings->gateway_password);
-
+
+ /* Check RD gateway type setting and set options appropriately. */
+ switch(guac_settings->gateway_type) {
+
+ /* Gateway is set to auto, so enable either transport. */
+ case GUAC_RDP_GATEWAY_AUTO:
+ rdp_settings->GatewayHttpTransport = TRUE;
+ rdp_settings->GatewayRpcTransport = TRUE;
+ break;
+
+ /* Gateway is forced to HTTP, so only enable HTTP transport. */
+ case GUAC_RDP_GATEWAY_HTTP:
+ rdp_settings->GatewayHttpTransport = TRUE;
+ rdp_settings->GatewayRpcTransport = FALSE;
+ break;
+
+ /* Gateway is forced to RPC, so only enable RPC transport. */
+ case GUAC_RDP_GATEWAY_RPC:
+ rdp_settings->GatewayHttpTransport = FALSE;
+ rdp_settings->GatewayRpcTransport = TRUE;
Review Comment:
I think we should add a block in the freerdp3 part (`HAVE_SETTERS_GETTERS`):
```c
freerdp_settings_set_bool(rdp_settings, FreeRDP_GatewayHttpTransport, TRUE)
freerdp_settings_set_bool(rdp_settings, FreeRDP_GatewayRpcTransport, TRUE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
