jmuehlner commented on code in PR #546:
URL: https://github.com/apache/guacamole-server/pull/546#discussion_r1747736321
##########
src/protocols/rdp/rdp.c:
##########
@@ -194,21 +247,11 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
primary->MemBlt = guac_rdp_gdi_memblt;
primary->OpaqueRect = guac_rdp_gdi_opaquerect;
- /* Load "rdpgfx" plugin for Graphics Pipeline Extension */
- if (settings->enable_gfx)
- guac_rdp_rdpgfx_load_plugin(context);
-
- /* Load plugin providing Dynamic Virtual Channel support, if required */
- if (freerdp_settings_get_bool(GUAC_RDP_CONTEXT(instance)->settings,
FreeRDP_SupportDynamicChannels) &&
- guac_freerdp_channels_load_plugin(context, "drdynvc",
- GUAC_RDP_CONTEXT(instance)->settings)) {
- guac_client_log(client, GUAC_LOG_WARNING,
- "Failed to load drdynvc plugin. Display update and audio "
- "input support will be disabled.");
- }
+ #ifndef RDP_INST_HAS_LOAD_CHANNELS
+ rdp_freerdp_load_channels(instance);
Review Comment:
That's better, but I think it might be worth just saying something about
using this callback if available, not tying this behavior to a specific version
that's not even checked in the configure check.
There's no guarantee that FreeRDP could release a 2.x version that _does_
have this callback if they wanted to, in which case this comment would be wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
