jmuehlner commented on code in PR #360:
URL: https://github.com/apache/guacamole-server/pull/360#discussion_r1733607115


##########
src/guacd/daemon.c:
##########
@@ -320,6 +321,14 @@ int main(int argc, char* argv[]) {
     /* General */
     int retval;
 
+#ifdef HAVE_DECL_PTHREAD_SETATTR_DEFAULT_NP
+    /* Set default stack size of 8MB */

Review Comment:
   I don't love having the value of the constant specified here in the constant 
- it's an opportunity for things to get out of sync if somebody later updates 
the value of `GUACD_THREAD_STACK_SIZE`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to