I think I understand what you're getting at. My comments: Anything to reduce administration time is a benefit. Allowing an admin or user to template their connection info would help
I would think that fields for username/password/template with approve (and possible changes in what the template provides) with a one-click add button would be ideal. FYI: I created a bash script for admins to add users to our guac server effectively doing the same as a template through the GUI . The script updates the guac postgres database directly (as well as creating a virtual AWS developer instance). Basically, a quick & easy way for our admins to add users. Since deleting users in the GUI is easy, I didn't create a script for that. So maybe a command-line script to add users with a template could be done that is not database dependent. Just my 2 cents worth. Mark -----Original Message----- From: necouchman (via GitHub) <[email protected]> Sent: Tuesday, June 20, 2023 9:20 PM To: [email protected] Subject: [GitHub] [guacamole-client] necouchman opened a new pull request, #892: GUACAMOLE-1798: Add extension that supports connection templates. necouchman opened a new pull request, #892: URL: https://github.com/apache/guacamole-client/pull/892 I've taken (another) run at this, this time using a decorating extension. Before I spend a bunch of time fixing up the myriad issues with this approach, I figured I'd solicit feedback on whether this is even a desirable approach, or if I should pursue some other route...or if it's something worth doing at all. At present, it _should_: * Present a selection box that lists the other connections the current user has access to, allowing you to select one of them as a "template". * Merge the connection parameters from the selected "template" connection, overriding those with any set locally in that configuration, before connecting. * Prevents you from selecting the connection you're editing as the template. Among the several issues that need to be resolved, assuming this is a sane/desirable approach: * Connections are not filtered by protocol, so you could "template" a SSH connection with a RDP connection, for example. Probably not ideal. * Connection Attributes are not merged, only the `GuacamoleConfiguration` (parameters). * Style/UX: Selection box isn't a constant size * Style/UX: Selection box shows the paging at the bottom, rather than being a scrolling list. * Style/UX: No indication on the page you're editing of parameter values from the template (not sure this is solvable with this particular method). All that said, I'm putting it in draft mode, for now - I appreciate any thoughts/comments/guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
