maglub commented on PR #766:
URL: https://github.com/apache/guacamole-client/pull/766#issuecomment-1504101091
It is quite weird that this change did not make it into neither the
Dockerfile for the 1.5.0, nor 1.5.1-RC1 docker containers that are available on
Dockerhub. When trying to start these containers, I get an error that `unzip`
is not found.
In the Dockerfile:
```
RUN apt-get update -qq \
&& apt-get install -y xmlstarlet unzip\
&& rm -rf /var/lib/apt/lists/*
```
* The change is correct in the Master branch, but not in the staging/1.5.1
branch
* But, this `apt-get` is not yet merged into the branch `stage/1.5.1`.
* It is also not available in the tag `1.5.1-RC1`
(https://github.com/apache/guacamole-client/blob/1.5.1-RC1/Dockerfile)
That it did not make it into 1.5.0, I can understand. It was probably a
mistake that could easily happen, but the change is correct in the master
branch. I am quite surprised, though, that nobody tried to run the docker
container for a month (the one here, which is broken
https://hub.docker.com/layers/guacamole/guacamole/1.5.0/images/sha256-b5e3e65ce76c6f33d12fe652133c1b945a2431bafd8ae0d7eb3c5c5883e95d2d?context=explore)
I suggest that we cherry pick the Dockerfile from master, putting it into at
least the `staging/1.5.1-RC1` branch, or to create a branch `staging-1.5.0.1`,
fixing it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
