jmuehlner commented on code in PR #826: URL: https://github.com/apache/guacamole-client/pull/826#discussion_r1160373328
########## guacamole-docker/bin/build-guacamole.sh: ########## @@ -43,10 +43,14 @@ ## to empty string. Can be set to "lgpl-extensions" to e.g. include ## RADIUS authentication extension. ## +## @param MAVEN_ARGUMENTS +## Any number of arbitrary extra arguments to be passed to maven. +## BUILD_DIR="$1" DESTINATION="$2" BUILD_PROFILE="$3" +MAVEN_ARGUMENTS="$4" Review Comment: I'm not sure if there is a better way to do this ... as it is you'd have to invoke it like `build-guacamole.sh "/tmp/some-path" "/opt/guacamole" "" -DskipTests=false` if you wanted to not pass anythin g for `$BUILD_PROFILE`, but still pass something for `$MAVEN_ARGUMENTS` - inserting a dummy argument to pad out the argument count to make sure the maven arguments get to the right place. Thoughts? ########## guacamole-docker/bin/build-guacamole.sh: ########## @@ -43,10 +43,14 @@ ## to empty string. Can be set to "lgpl-extensions" to e.g. include ## RADIUS authentication extension. ## +## @param MAVEN_ARGUMENTS +## Any number of arbitrary extra arguments to be passed to maven. +## BUILD_DIR="$1" DESTINATION="$2" BUILD_PROFILE="$3" +MAVEN_ARGUMENTS="$4" Review Comment: I'm not sure if there is a better way to do this ... as it is you'd have to invoke it like `build-guacamole.sh "/tmp/some-path" "/opt/guacamole" "" -DskipTests=false` if you wanted to not pass anything for `$BUILD_PROFILE`, but still pass something for `$MAVEN_ARGUMENTS` - inserting a dummy argument to pad out the argument count to make sure the maven arguments get to the right place. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
