necouchman commented on code in PR #783:
URL: https://github.com/apache/guacamole-client/pull/783#discussion_r1058581936
##########
.gitignore:
##########
@@ -1,2 +1,3 @@
*~
target/
+.vscode/
Review Comment:
Adding .gitignore entries is fine, I'm just not sure it should be part of
this change.
##########
guacamole/src/main/java/org/apache/guacamole/rest/user/UserResource.java:
##########
@@ -150,6 +150,10 @@ public void updateObject(APIUser modifiedObject) throws
GuacamoleException {
throw e;
}
+ /* Force updateObject to save the timezone when it is empty */
+ if (modifiedObject.getAttributes().get("timezone") == null)
+ modifiedObject.getAttributes().put("timezone", "");
+
Review Comment:
As mentioned on the Jira issue, I'm curious why setting an empty string is
required or preferable to having a `null` or non-existent value? It doesn't
look like this change provides any functionality based on that, just changes it
to an empty string? Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
