Comments below inline.
Cheers, Paul.
On Wed, Aug 25, 2021 at 3:53 AM Milles, Eric (TR Technology) <
eric.mil...@thomsonreuters.com> wrote:
> Two notes so far:
>
>
>
> 1) GROOVY-9966 was introduced to 2_5_X with this release. It is a pretty
> minor bug, but could be easily fixed if the release ends up being respun.
>
I cherry-picked your commit onto that branch.
> 2) GROOVY-10159 was "fixed" in this release but it introduces a
> potentially more worrisome issue:
>
>
>
> public class Main {
>
> static final String foo = 1 + 1
>
> static main(args) {
>
> print(foo)
>
> }
>
> }
>
>
>
> This class will print "11" not "2" due to the change in
> ExpressionUtils#transformBinaryConstantExpression
>
I'm not sure about the severity of this issue in terms of cancelling the
release since it only impacts code that would never compile previously and
could possibly be release noted, but in any case, I have made a commit on
master which I believe avoids the problem. It just avoids trying to
optimise troublesome cases - and so is handled by the normal non-optimised
code paths. We would need further work to try to make the optimisation
smarter and in fact handle this case. So we could do that later. If you
think the commit on master addresses your concern, let me know and I can
merge onto the other branches and then I might as well re-roll the releases.
>
>
> *From:* Paul King <pa...@asert.com.au>
> *Sent:* Tuesday, August 24, 2021 6:07 AM
> *To:* Groovy_Developers <dev@groovy.apache.org>
> *Subject:* [EXT] [VOTE] Release Apache Groovy 2.5.15
>
>
>
> *External Email:* Use caution with links and attachments.
>
>
>
>
>
> Dear development community,
>
> I am happy to start the VOTE thread for a Groovy 2.5.15 release!
>
> This release includes 34 bug fixes/improvements as outlined in the
> changelog:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12349466
> <https://urldefense.com/v3/__https:/issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12349466__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLff2pYxA$>
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_15
> <https://urldefense.com/v3/__https:/gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs*tags*GROOVY_2_5_15__;Ly8!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLF2pQSbo$>
> Tag commit id: b6944ec31d2faf1b5e44e411e5a4cc68e639fd1c
>
> The artifacts to be voted on are located as follows (r49617).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.15/sources
> <https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/dev/groovy/2.5.15/sources__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLwz19am8$>
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.5.15/distribution
> <https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/dev/groovy/2.5.15/distribution__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLDLbYgA8$>
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/release/groovy/KEYS
> <https://urldefense.com/v3/__https:/dist.apache.org/repos/dist/release/groovy/KEYS__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmL5aFh8Pg$>
>
> Please vote on releasing this package as Apache Groovy 2.5.15.
>
> Reminder on ASF release approval requirements for PMC members:
> http://www.apache.org/legal/release-policy.html#release-approval
> <https://urldefense.com/v3/__http:/www.apache.org/legal/release-policy.html*release-approval__;Iw!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLcpViK70$>
> Hints on validating checksums/signatures (but replace md5sum with
> sha256sum):
> https://www.apache.org/info/verification.html
> <https://urldefense.com/v3/__https:/www.apache.org/info/verification.html__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLOFtjAnU$>
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.5.15
> [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.5.15 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
>
> [image: Image removed by sender.]
> <https://urldefense.com/v3/__https:/www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLmj9_WAc$>
>
> Virus-free. www.avast.com
> <https://urldefense.com/v3/__https:/www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail__;!!GFN0sa3rsbfR8OLyAw!Pcx9GcDwdQGmFOtS-tnJFc5gRkCU-oCf7UL1XiEZq-LlhZGG3yjoqK69QnKShCmLmj9_WAc$>
>
>
>
