I'm a little concerned with the recent ClassHelper changes that have impacted the meaning of "dynamic-typed" for fields, variables, parameters, etc. Previously "type == DYNAMIC_TYPE" was the test. For me this was true for "def x" and "public x" but false for "Object x". Now isDynamicTyped(ClassNode) is true for all 3 and I think may be true for type parameters like "T -> Object" (no bound type). I wonder if it is time to deprecate the isDynamic* APIs.
notes: FieldNode#isDynamicTyped Parameter#isDynamicTyped MethodNode#isDynamicReturnType ResolveVisitor#visitCatchStatement StaticTypeCheckingVisitor#visitForLoop Checking isObjectType and isDynamicTyped is redundant. From: Guillaume Laforge <glafo...@gmail.com> Sent: Thursday, May 20, 2021 6:57 AM To: Groovy_Developers <dev@groovy.apache.org>; Paul King <pa...@asert.com.au> Subject: Re: [VOTE] Release Apache Groovy 4.0.0-beta-1 +1 I had a minor issue with the Spock framework dependency (solved over Slack with Paul); but other than that, tests passed, smoke manual tests with the Groovy console were working as expected. Guillaume On Thu, May 20, 2021 at 12:42 PM Paul King <pa...@asert.com.au<mailto:pa...@asert.com.au>> wrote: Dear development community, I am happy to start the VOTE thread for a Groovy 4.0.0-beta-1 release! This release includes 58 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12350080<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fsecure%2FReleaseNote.jspa%3FprojectId%3D12318123%26version%3D12350080&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470007904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2BOki8sz71S%2BNR9i0gTXVmOCY1bAFXE4Lm5UsZZKOlA%3D&reserved=0> Tag: https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_4_0_0_BETA_1<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%3Fp%3Dgroovy.git%3Ba%3Dtag%3Bh%3Drefs%2Ftags%2FGROOVY_4_0_0_BETA_1&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470007904%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=T3PbkcgYPefYi5JMQFBnYMO5Z%2FujiNvGV%2Fd%2FZJY0Vnk%3D&reserved=0> Tag commit id: a38acfbb37ea83b0e213525d4bb2faed0dee0ef5 The artifacts to be voted on are located as follows (r-1). Source release: https://dist.apache.org/repos/dist/dev/groovy/4.0.0-beta-1/sources<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fgroovy%2F4.0.0-beta-1%2Fsources&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470017896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=IAiqXv589rQH5%2Fe3QH6veedYdqxES1SUgbl7V5lgG2U%3D&reserved=0> Convenience binaries: https://dist.apache.org/repos/dist/dev/groovy/4.0.0-beta-1/distribution<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fgroovy%2F4.0.0-beta-1%2Fdistribution&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470027888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FY2qmqmFAoUPxPozZo0f%2FJ5T34qf9pwzFUe7bL5FkjM%3D&reserved=0> Release artifacts are signed with a key from the following file: https://dist.apache.org/repos/dist/release/groovy/KEYS<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Fgroovy%2FKEYS&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470027888%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RtFUucp5tWuGB2CV9Ao9FRumQz0r8DM%2BeDT4sdOF%2BQ0%3D&reserved=0> Please vote on releasing this package as Apache Groovy 4.0.0-beta-1. Reminder on ASF release approval requirements for PMC members: http://www.apache.org/legal/release-policy.html#release-approval<https://nam02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flegal%2Frelease-policy.html%23release-approval&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470037884%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WvQ5wtNjPXNNW0CiV81bMhcDivWkS1kn3foTcwCeA6I%3D&reserved=0> Hints on validating checksums/signatures (but replace md5sum with sha256sum): https://www.apache.org/info/verification.html<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.apache.org%2Finfo%2Fverification.html&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470037884%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1kcRDFO9Lgz7wGv4hP2pVvGkf%2Fxnm19%2BTQPQPyHbH38%3D&reserved=0> Reminder that you need gradle 5 or above for the bootstrap step if building from sources and if you are on a flaky network, last resort if you are having trouble might be to disable dependency verification: https://docs.gradle.org/current/userguide/dependency_verification.html#sec:disabling-verification<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.gradle.org%2Fcurrent%2Fuserguide%2Fdependency_verification.html%23sec%3Adisabling-verification&data=04%7C01%7Ceric.milles%40thomsonreuters.com%7C1ea02933716344a8563308d91b866f79%7C62ccb8646a1a4b5d8e1c397dec1a8258%7C0%7C0%7C637571086470047875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=agBPMhSxhbGjPHIi3vLsUvkD52SZFCDyUOPxX9krteM%3D&reserved=0> The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release Apache Groovy 4.0.0-beta-1 [ ] 0 I don't have a strong opinion about this, but I assume it's ok [ ] -1 Do not release Apache Groovy 4.0.0-beta-1 because... Here is my vote: +1 (binding)
