We can certainly look at this. There is quite a bit of historic code in that package which could be moved elsewhere. I recommend doing that outside this issue.
On Sat, Feb 1, 2020 at 9:37 PM Jochen Theodorou <blackd...@gmx.org> wrote: > On 01.02.20 01:02, sun...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > sunlan pushed a commit to branch GROOVY_3_0_X > > in repository https://gitbox.apache.org/repos/asf/groovy.git > > > > commit 2661c787da9fcaa7451f3f78556ce0b32530a1a1 > > Author: Paul King <pa...@asert.com.au> > > AuthorDate: Fri Jan 31 08:44:13 2020 +1000 > > > > GROOVY-9380: VMPlugin refactor: Coalesce Java5 through Java7 into > Java8 > > > > (cherry picked from commit 697bf094a40b9afda80ae1da0b431c26ec5a3ca3) > [...] > > I think this kind of refactoring should actually go one step further and > move configureTypeVariableDefinition, configureClass, > configureTypeVariableReference, setRetentionPolicy, > setMethodDefaultValue as compiler specific static methods out of the > VMplugin into the compiler. It made kind of sense to have these in the > past and past means really that Groovy is not requiring at least Java5. > When we required at least Java5 it was just laziness to keep them there > (or we had better things to do), but since you decided to move them now > I would recommend to do it "proper". > > bye Jochen >
