Aha! Good call. Didn’t change my vote so +1 stands.
Sent from my primitive Tricorder > On 12 Oct 2018, at 14:52, Cédric Champeau <cedric.champ...@gmail.com> wrote: > > Indeed this works. Changing to +1 then. > >> Le ven. 12 oct. 2018 à 14:50, Paul King <pa...@asert.com.au> a écrit : >> Yes works for me on 4 OSs so long as GROOVY_HOME isn't hard-coded to some >> other value. >> And I observe the same behavior as reported by Cédric with 2.5.2 when >> GROOVY_HOME is hard-coded. >> >> Cheers, Paul. >> >>> On Fri, Oct 12, 2018 at 10:42 PM John Wagenleitner >>> <john.wagenleit...@gmail.com> wrote: >>> This can be caused by having GROOVY_HOME pointing to a different release, >>> unsetting that environment variable or setting to the 2.5.3 directory >>> should fix it. >>> >>>> On Fri, Oct 12, 2018 at 1:05 AM Cédric Champeau >>>> <cedric.champ...@gmail.com> wrote: >>>> At this point, -1. See below. >>>> >>>> $ gpg --verify apache-groovy-src-2.5.3.zip.asc >>>> gpg: assuming signed data in 'apache-groovy-src-2.5.3.zip' >>>> gpg: Signature made Thu 11 Oct 2018 07:34:42 AM CEST >>>> gpg: using RSA key 6A65176A0FB1CD0B >>>> gpg: Good signature from "Paul King <pa...@apache.org>" [unknown] >>>> gpg: aka "Paul King <pa...@asert.com.au>" [unknown] >>>> gpg: aka "Paul King <paul.king.as...@gmail.com>" [unknown] >>>> gpg: aka "Paul King <ki...@ociweb.com>" [unknown] >>>> gpg: aka "keybase.io/paulk_asert <paulk_as...@keybase.io>" >>>> [unknown] >>>> >>>> $ sha256sum apache-groovy-src-2.5.3.zip >>>> 7fe017485a22afa1357bd5223872304ac04525474b9a68e84f57c522d9078380 >>>> apache-groovy-src-2.5.3.zip >>>> $ cat apache-groovy-src-2.5.3.zip.sha256 >>>> 7fe017485a22afa1357bd5223872304ac04525474b9a68e84f57c522d9078380 >>>> >>>> $ cd groovy-2.5.3 >>>> $ gradle -b wrapper.gradle wrapper >>>> $ ./gradlew dist --scan >>>> >>>> https://scans.gradle.com/s/pwkrb6rzrqzyu >>>> >>>> It seems the build needs to be fixed again: it's not fetched from cache >>>> after a "clean" anymore, so probably something broke caching. See >>>> https://scans.gradle.com/s/pwkrb6rzrqzyu/timeline?showCache&task=kd7f3knycujqg >>>> >>>> $ cd target >>>> $ unzip apache-groovy-binary-2.5.3.zip >>>> $ cd groovy-2.5.3 >>>> $ bin/groovy -version >>>> Error: Could not find or load main class >>>> org.codehaus.groovy.tools.GroovyStarter >>>> Caused by: java.lang.ClassNotFoundException: >>>> org.codehaus.groovy.tools.GroovyStarter >>>> >>>> $ cd bin >>>> $ ./groovy -version >>>> Error: Could not find or load main class >>>> org.codehaus.groovy.tools.GroovyStarter >>>> Caused by: java.lang.ClassNotFoundException: >>>> org.codehaus.groovy.tools.GroovyStarter >>>> >>>> So it seems the start scripts are broken. >>>> >>>>> Le ven. 12 oct. 2018 à 09:39, Andres Almiray <aalmi...@gmail.com> a écrit >>>>> : >>>>> +1 (binding) >>>>> >>>>> All tests ran OK. >>>>> Tested local 2.5.3 with JaCoCo regarding a pending PR on @Gnenerated >>>>> support: all good as well. >>>>> >>>>> ------------------------------------------- >>>>> Java Champion; Groovy Enthusiast >>>>> JCP EC Associate Seat >>>>> http://andresalmiray.com >>>>> http://www.linkedin.com/in/aalmiray >>>>> -- >>>>> What goes up, must come down. Ask any system administrator. >>>>> There are 10 types of people in the world: Those who understand binary, >>>>> and those who don't. >>>>> To understand recursion, we must first understand recursion. >>>>> >>>>> >>>>>> On Thu, Oct 11, 2018 at 5:55 AM Paul King <pa...@asert.com.au> wrote: >>>>>> Dear development community, >>>>>> >>>>>> I am happy to start the VOTE thread for a Groovy 2.5.3 release! >>>>>> >>>>>> This release includes 52 bug fixes/improvements as outlined in the >>>>>> changelog: >>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12343876 >>>>>> >>>>>> Tag: >>>>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_5_3 >>>>>> Tag commit id: 676d5a7d66f540a831779c208878df39d08938b5 >>>>>> >>>>>> The artifacts to be voted on are located as follows (r30001). >>>>>> Source release: >>>>>> https://dist.apache.org/repos/dist/dev/groovy/2.5.3/sources >>>>>> Convenience binaries: >>>>>> https://dist.apache.org/repos/dist/dev/groovy/2.5.3/distribution >>>>>> >>>>>> Release artifacts are signed with a key from the following file: >>>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS >>>>>> >>>>>> Please vote on releasing this package as Apache Groovy 2.5.3. >>>>>> >>>>>> Reminder on ASF release approval requirements for PMC members: >>>>>> http://www.apache.org/legal/release-policy.html#release-approval >>>>>> Hints on validating checksums/signatures (but replace md5sum with >>>>>> sha256sum): >>>>>> https://www.apache.org/info/verification.html >>>>>> >>>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>>> least three +1 PMC votes are cast. >>>>>> >>>>>> [ ] +1 Release Apache Groovy 2.5.3 >>>>>> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >>>>>> [ ] -1 Do not release Apache Groovy 2.5.3 because... >>>>>> >>>>>> Here is my vote: >>>>>> >>>>>> +1 (binding) >>>>>>
