Okay, I'm about to start a new vote count. I re-jigged the release process a bit to keep signing strictly local. Also, the glitch from the previous release should be fixed and I re-worked the bootstrapping so that gradle versions 3+ should also work.
Cheers, Paul. On Fri, Dec 30, 2016 at 7:54 PM, Paul King <pa...@asert.com.au> wrote: > Darn. Thanks for spotting that. Yes I fixed that on master previously > but didn't notice that I forgot to merge the fix when backporting and > CI was failing for a different reason so I ignored what I thought was > a false positive. > > It's only test code, not prod code that is affected but I think it's > worth fixing to avoid any confusion with building from src. I'll wait > another day for any other feedback and then I'll re-release the > artifacts. > > Cheers, Paul. > > On Fri, Dec 30, 2016 at 7:24 PM, Pascal Schumacher > <pascalschumac...@gmx.net> wrote: >> Hello Paul, >> >> thanks a lot for volunteering as a release manager. :) >> >> Sadly the javadoc of StringGroovyMethods#uncapitalize contains an error so, >> the unit tests fail with: >> >> MainJavadocAssertionTest > >> StringGroovyMethodsJavadocAssertionTest.testAssertionFromStringGroovyMethodsLine213 >> FAILED >> >> Assertion failed: >> >> assert 'Hello World' == 'hello world'.split(' ').collect{ it.uncapitalize() >> }.join(' ') >> >> | | | | >> >> false | [hello, world] hello world >> >> [hello, world] >> >> >> Am 30.12.2016 um 07:25 schrieb Paul King: >> >> Dear community, >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release! >> >> This release includes 82 bug fixes/improvements as outlined in the >> changelog: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 >> >> Tag: >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8 >> Tag commit id: 0911b621d2b9eb9de1edc4743dc12ee0b201db5f >> >> The artifacts to be voted on are located as follows. >> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources >> Convenience binaries: >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution >> SVN version id: 17618 >> >> Release artifacts are signed with the following key: >> https://dist.apache.org/repos/dist/dev/groovy/KEYS >> >> Please vote on releasing this package as Apache Groovy 2.4.8. >> >> Officially, the vote is open for the next 72 hours and passes if a >> majority of at least three +1 PMC votes are cast. Given the time of >> year, I'll wait an extra day before sending a vote summary. >> >> [ ] +1 Release Apache Groovy 2.4.8 >> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >> [ ] -1 Do not release Apache Groovy 2.4.8 because... >> >> Here is my vote: >> >> +1 (binding) >> >>