I agree we should also try the new parser on a handful of other popular projects, as it'd ensure the parser can parse even more of Groovy that is in the wild.
Le dimanche 9 octobre 2016, Thibault Kruse <tibokr...@googlemail.com> a écrit : > Should the new parser also pass tests for the most-used frameworks > before being merged? Grails, Gradle, Spock and Geb come to my mind. > > On Fri, Oct 7, 2016 at 8:40 PM, Jochen Theodorou <blackd...@gmx.org > <javascript:;>> wrote: > > > > > > On 07.10.2016 13:35, daniel_sun wrote: > >> > >> I see. > >> > >> Feel free to merge the new parser back when you think it is mature and > >> ready to go home ;) Currently The parser is lack of some syntax > >> checks(e.g. continue should only be used in loop) and friendly messages > >> for developers. > > > > > > Before that I would like the parser to be able to parse the same files > and > > have no test cases failing. Because as part of the merge we need to > > integrate the parser in the test cycle to avoid any problems if we change > > the syntax after all. I know we said we would not, but it happened at > least > > 3(?) this year. > > > > bye Jochen > -- Guillaume Laforge Apache Groovy committer & PMC Vice-President Developer Advocate @ Google Cloud Platform Blog: http://glaforge.appspot.com/ Social: @glaforge <http://twitter.com/glaforge> / Google+ <https://plus.google.com/u/0/114130972232398734985/posts>
