Changed to +1 after discussion in weekly meeting
On 2026/08/18 19:14:30 Scott Murphy Heiberg wrote: > -1 > > 1. Every time we add to grails-core, it makes the entire build process slower > and more flaky. I have yet to create a single PR that resulted in a stable > build even though it ran locally on my machine. I have wasted hours and > hours of my time going through very long stack traces that are just the > result of a flaky build. Then re-running the build and having to wait hours > just to find out there was nothing wrong with the tests in the first place? > We need to stabilize the build process before adding anything more to it. > > 2. Is grails-quartz an integral part of grails-core? I would argue no. I > would even argue there are better modern alternatives than quartz. This goes > against the principle of SOC and just continues to grow a repo that is > already struggling to maintain control. Is this repo currently subjected to > Apache rules? If not, should it be or is it better to keep it free and > independent? > > 3. Probably most important, PRs now go for weeks on grails-core without > reviews. Adding another repo and subjecting it to a more stringent approval > process is a step backwards for the quartz plugin itself. Currently > grails-core has 78 PRs spanning several months > https://github.com/apache/grails-core/pulls Anyone voting to add more > projects to grails-core, should first consider reviewing the 78 PRs we > currently have open. > > 4. If I run a full sweep build on my MacBook M4 MAX, it frequently overheats > and crashes my laptop to the point I have to force restart it. Adding more to > the build is just going to make it worse and add more to github actions that > currently take ~6 hours to get green. > > 5. There are tests and components in grails-core/ currently that don't even > build, are unused, and completely broken. We should focus on cleaning up or > fixing all the dead code. My fear is this will just add to that in the long > term. > > In summary, I would be +1 if > 1. GitHub actions were stabilized and build actually worked > 2. GitHub actions could be completed in 1 hour or less. > 3. Outstanding PRs were actively reviewed or rejected. > > On 2026/08/16 14:47:04 James Daugherty wrote: > > Per https://lists.apache.org/thread/jj2npk1mnm4wynx8y8l3o7yz4hvfbf7v , > > I propose we merge grails-quartz > > (https://github.com/apache/grails-quartz) into grails-core > > (https://github.com/apache/grails-core). > > > > Please vote: > > > > +1 yes > > +0 abstain > > -1 no (explain) > > >
