matrei commented on code in PR #1164:
URL:
https://github.com/apache/grails-spring-security/pull/1164#discussion_r2336436247
##########
plugin-cas/plugin/src/main/groovy/grails/plugin/springsecurity/cas/SpringSecurityCasGrailsPlugin.groovy:
##########
@@ -101,6 +101,12 @@ class SpringSecurityCasGrailsPlugin extends Plugin {
// TODO document NullProxyGrantingTicketStorage
casProxyGrantingTicketStorage(ProxyGrantingTicketStorageImpl)
+ ["serverUrlPrefix", "loginUri", "serviceUrl"].each {
requiredConfigKey ->
Review Comment:
- Single quotes for strings?
- Do we want to move this check up? Perhaps after:
```groovy
if (printStatusMessages) {
println '\nConfiguring Spring Security CAS ...'
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
