+1 Gianluca Sartori
On Wed, 23 Apr 2025 at 21:00, James Fredley <jamesfred...@apache.org> wrote: > Hi Everyone, > > As per the [DISCUSS] int the weekly meeting this morning [1], I'd like to > propose we consolidate grails-profiles & grails-wrapper into grails-core. > > grails-core:grails-bom references the versions of grails-profiles and > combining grails-profiles into grails-core allows them to released and > voted on at the same time. grails-profiles should have regular changes, > like grails-forge has had, going forward. > > grails-profiles includes grails-wrapper.jar in two locations which comes > from grails-wrapper:starter. For ASF releases we should not include > compiled files in the source and adding grails-wrapper to grails-core will > allow us to include it from the build instead. > > https://github.com/apache/grails-wrapper/blob/7.0.x/starter/build.gradle > > https://github.com/apache/grails-profiles/blob/7.0.x/base/skeleton/grails-wrapper.jar > > https://github.com/apache/grails-profiles/blob/7.0.x/profile/skeleton/grails-wrapper.jar > which is the primary reason to include grails-wrapper in grails-core for > grails-profiles. grails-wrapper will also be updated to publish the > starter jar (grails-wrapper.jar). > > grails-forge also includes grails-wrapper.jar in one location, but there > is a desire to keep grails-forge separate and grails-wrapper.jar will be > included from the published location instead of being committed in source. > > > The vote is open for the next 72 hours and passes if all binding votes are > cast in favor. > > [] +1 proceed with the proposal > [] 0 I don't have a strong opinion about this, but I assume it's ok > [] -1 Do not proceed because ... > > Here is my vote: > > +1 (binding) > > -James > > [1] > https://docs.google.com/document/d/1L590r6Z_xNQ48l31Yolsir75dUgAorEnTWmW1kGqJrw/edit?tab=t.0#heading=h.yzvjivh6d3yb >
