Le lun. 22 mars 2021 à 23:15, Florent Guillaume <fguilla...@nuxeo.com> a écrit :
> Hi, > > I can drop the private constructor if you want. > I'm surprised it's needed though, as the default instance is already used > by the code if no value is provided for the timeProvider parameter of > TransactionImpl. > Got that from your comment on the ticket but tomee makes bean wiring of the tomee.xml/resources.xml configurable, this means you can make the impl of this bean configurable. TomEE will support a factory method (getInstance like) or constructor args but then it means other impls will need that as well whereas they would likely just use a "new" instantiation IMHO. So to ensure you can switch the impl just with a -Dxxxx=MyImpl or -Dxxx=o.a.g....SystemCurrentTime (I'm simplifying names and overall system ;)), being able to instantiate an instance of the default makes sense to me. This does not mean your default wiring is not correct - it is, it is just not aligned on some configuration mecanism. Why i asked tomee dev on the ticket is that tomee can wrap SystemCurrentTime to make it instantiable so wondered if it is what is expected vs having it instantiable OOTB. Hope it makes more sense this way. > > Florent > > > On Mon, Mar 22, 2021 at 5:49 PM Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > >> Hi Richard, >> >> I still think SystemCurrentTime should have a public noarg constructor >> (or just drop the private one) since it will enable tomee to fully >> configure dynamically the tx mgr with this new feature but otherwise +1 to >> apply them all. >> >> Romain Manni-Bucau >> @rmannibucau <https://twitter.com/rmannibucau> | Blog >> <https://rmannibucau.metawerx.net/> | Old Blog >> <http://rmannibucau.wordpress.com> | Github >> <https://github.com/rmannibucau> | LinkedIn >> <https://www.linkedin.com/in/rmannibucau> | Book >> <https://www.packtpub.com/application-development/java-ee-8-high-performance> >> >> >> Le lun. 22 mars 2021 à 17:03, Zowalla, Richard < >> richard.zowa...@hs-heilbronn.de> a écrit : >> >>> Hi all, >>> >>> wanted to raise attention on this again. 6792 would be very nice as we >>> should allow TLS/SSL protocol versions for a given mail server instead >>> of falling back to some hard-coded default. >>> >>> Gruss >>> Richard >>> >>> Am Mittwoch, den 24.02.2021, 09:33 +0100 schrieb Romain Manni-Bucau: >>> > Hi all, >>> > >>> > AFAIK we have a few pending patches to apply/issue to close: >>> > >>> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6792: update >>> > some defaults and config capacity >>> > - [mail] https://issues.apache.org/jira/browse/GERONIMO-6801 and >>> > https://issues.apache.org/jira/browse/GERONIMO-6800 (setText) >>> > - [transaction-manager] >>> > https://issues.apache.org/jira/browse/GERONIMO-6805: enable to change >>> > the time evaluator impl >>> > >>> > If someone else can have a review it would be great (feel free to >>> > apply the patch or I can do it after). >>> > >>> > note: some of the patches are waiting for some feedback - in >>> > particular txmgr one, wonder about tomee <resource> usage which can >>> > need to remove the private constructor of the default impl to enable >>> > to configure the impl completely. >>> > >>> > Thanks, >>> > Romain Manni-Bucau >>> > @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book >>> >>> > > -- > [image: Nuxeo Logo] <https://www.nuxeo.com/> > > Florent Guillaume Head of R&D [image: LinkedIn] > <https://www.linkedin.com/in/fguillaume/> [image: Twitter] > <https://twitter.com/efge> [image: Github] <https://github.com/efge> > > Nuxeo Content Services Platform. Stay ahead. >
