Running findbugs for example on each build makes sense to me at dev time. Running rat doesn't because most of the time one is changing an existing file and not adding new ones. Running rat at release time (as the name of the tool suggests) or deploy time make sense to me as that's when we want to make sure everything is in proper shape. So, my preference as mentioned before is to run it in the deploy phase as it still will catch the problems early but won't fail builds for silly reasons.
Jarek On Wed, May 29, 2013 at 11:19 AM, Romain Manni-Bucau <[email protected]> wrote: > Hi > > i like to get it by default, > > @Jarek: rat can be skipped with a system property, isn't it enough for dev > time? > > Romain Manni-Bucau > Twitter: @rmannibucau > Blog: http://rmannibucau.wordpress.com/ > LinkedIn: http://fr.linkedin.com/in/rmannibucau > Github: https://github.com/rmannibucau > > > > 2013/5/29 Jarek Gawor <[email protected]> >> >> I don't know about others but my source tree is usually polluted with >> patch files and other files that I create during >> development/testing/debugging. With Rat enabled by default my build >> will fail (as it does currently after doing svn up on xbean). So I >> would prefer to either delay RAT until the deploy phase or just enable >> RAT on the buildbot setup for xbean. >> >> Jarek >> >> >> On Wed, May 29, 2013 at 5:01 AM, Mark Struberg <[email protected]> wrote: >> > hi folks! >> > >> > I've enabled apache-rat in the whole xbean build. Which means the build >> > is now defunct due to a few missing licenses. >> > Hope we gonna fix those soon... >> > >> > LieGrue, >> > strub > >
