----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52812/#review152422 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Oct. 12, 2016, 4:32 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52812/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 4:32 p.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: GOEDE-1999 > https://issues.apache.org/jira/browse/GOEDE-1999 > > > Repository: geode > > > Description > ------- > > Using try and finally to make sure the offheap reference will be released. > Make similar changes for the parrellel wan queue as well. > Also release offheap memory if a virtualPut failed to put the > GatewaySenderEnent into the sender queue. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractBucketRegionQueue.java > 8fa8597 > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java > 294b616 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java > 79b9d86 > > Diff: https://reviews.apache.org/r/52812/diff/ > > > Testing > ------- > > prechecking > > > Thanks, > > Eric Shu > >
