----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52751/#review152334 -----------------------------------------------------------
Fix it, then Ship it! Fix use of curlies and Ship It! geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java (line 734) <https://reviews.apache.org/r/52751/#comment221327> The style guide is to use curlies even for a single line block: if (locatorString.length()==0) { return; } - Kirk Lund On Oct. 12, 2016, 2:21 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52751/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:21 a.m.) > > > Review request for geode, Jared Stewart, John Blum, Kevin Duling, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1986: correctly set the flag indicating if cluster configuration > service is running or not on a locator. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 17303c1f984a90159f924a262d0ec843410cec16 > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > d166397e3d5897347500e5447637fb4b99895388 > > geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithEmbededLocatorDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52751/diff/ > > > Testing > ------- > > prechecking running > > > Thanks, > > Jinmei Liao > >
