----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52641/#review151830 -----------------------------------------------------------
geode-core/src/main/resources/javadoc-images/example-client-cache.xml (line 22) <https://reviews.apache.org/r/52641/#comment220371> this should be 7.0//EN, right? geode-core/src/test/java/org/apache/geode/cache30/CacheXml66DUnitTest.java (line 14) <https://reviews.apache.org/r/52641/#comment220372> The diff on this file is too garbled. I assume you just pulled methods from old superclasses that you've deleted and added them to this class. geode-core/src/test/resources/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest_single_pool.xml (line 24) <https://reviews.apache.org/r/52641/#comment220374> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-creation-with-eviction.xml (line 20) <https://reviews.apache.org/r/52641/#comment220375> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-creation-without-eviction.xml (line 20) <https://reviews.apache.org/r/52641/#comment220376> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-recovery-overflow.xml (line 20) <https://reviews.apache.org/r/52641/#comment220377> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache/query/internal/index/cachequeryindex.xml (line 19) <https://reviews.apache.org/r/52641/#comment220378> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache/query/internal/index/cachequeryindexwitherror.xml (line 19) <https://reviews.apache.org/r/52641/#comment220379> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/badScope.xml (line 20) <https://reviews.apache.org/r/52641/#comment220380> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/ewtest.xml (line 19) <https://reviews.apache.org/r/52641/#comment220381> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/examples_3_0/example-cache.xml (line 22) <https://reviews.apache.org/r/52641/#comment220385> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/examples_4_0/example-cache.xml (line 22) <https://reviews.apache.org/r/52641/#comment220386> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/malformed.xml (line 20) <https://reviews.apache.org/r/52641/#comment220382> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/partitionedRegion.xml (line 20) <https://reviews.apache.org/r/52641/#comment220383> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/cache30/partitionedRegion51.xml (line 20) <https://reviews.apache.org/r/52641/#comment220384> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/BackupJUnitTest.cache.xml (line 19) <https://reviews.apache.org/r/52641/#comment220387> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/PartitionRegionCacheExample2.xml (line 19) <https://reviews.apache.org/r/52641/#comment220388> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_bytes_threshold.xml (line 19) <https://reviews.apache.org/r/52641/#comment220389> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_dir.xml (line 19) <https://reviews.apache.org/r/52641/#comment220390> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_dir_size.xml (line 19) <https://reviews.apache.org/r/52641/#comment220391> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_max_oplog_size.xml (line 19) <https://reviews.apache.org/r/52641/#comment220392> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_roll_oplogs_value.xml (line 19) <https://reviews.apache.org/r/52641/#comment220393> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_sync_value.xml (line 19) <https://reviews.apache.org/r/52641/#comment220394> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_time_interval.xml (line 19) <https://reviews.apache.org/r/52641/#comment220395> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/mixed_diskstore_diskdir.xml (line 19) <https://reviews.apache.org/r/52641/#comment220396> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/mixed_diskstore_diskwriteattrs.xml (line 19) <https://reviews.apache.org/r/52641/#comment220397> This should be 7.0//EN geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testDTDFallbackWithNonEnglishLocal.cache.xml (line 20) <https://reviews.apache.org/r/52641/#comment220398> This should be 7.0//EN geode-cq/src/test/resources/org/apache/geode/internal/cache/tier/sockets/durablecq-client-cache.xml (line 19) <https://reviews.apache.org/r/52641/#comment220400> This should be 7.0//EN geode-cq/src/test/resources/org/apache/geode/internal/cache/tier/sockets/durablecq-server-cache.xml (line 19) <https://reviews.apache.org/r/52641/#comment220401> This should be 7.0//EN geode-spark-connector/geode-spark-connector/src/it/resources/test-regions.xml (line 20) <https://reviews.apache.org/r/52641/#comment220402> This should be 7.0//EN geode-spark-connector/geode-spark-connector/src/it/resources/test-retrieve-regions.xml (line 20) <https://reviews.apache.org/r/52641/#comment220403> This should be 7.0//EN - Bruce Schuchardt On Oct. 7, 2016, 5:12 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52641/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 5:12 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-1914 Removed old dtds from geode source code(kept 7.0 and above) > > Deteted old tests and updated test xmls to point 7.0 dtd > > > Diffs > ----- > > geode-core/src/main/resources/javadoc-images/example-client-cache.xml > bddeb9f > geode-core/src/main/resources/org/apache/geode/admin/doc-files/ds4_0.dtd > 6566af6 > geode-core/src/main/resources/org/apache/geode/admin/doc-files/ds5_0.dtd > d56fd4d > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache3_0.dtd > 44d42c2 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache4_0.dtd > d91d50e > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache4_1.dtd > d64968a > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache5_0.dtd > 34ca2a9 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache5_1.dtd > 4a93047 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache5_5.dtd > 090f7f9 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache5_7.dtd > 95e54fd > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache5_8.dtd > dc2ae73 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache6_0.dtd > 82bdc11 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache6_1.dtd > 3215fbc > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache6_5.dtd > 9798748 > geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache6_6.dtd > 0a2c2f2 > geode-core/src/test/java/org/apache/geode/cache/RegionFactoryJUnitTest.java > 9f31eb1 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml30DUnitTest.java > 187be8a > geode-core/src/test/java/org/apache/geode/cache30/CacheXml40DUnitTest.java > 952efb2 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml41DUnitTest.java > ae1a98d > geode-core/src/test/java/org/apache/geode/cache30/CacheXml45DUnitTest.java > 7c10524 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml51DUnitTest.java > 30925e5 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml55DUnitTest.java > fd52580 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml57DUnitTest.java > 833093d > geode-core/src/test/java/org/apache/geode/cache30/CacheXml58DUnitTest.java > 4040b15 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml60DUnitTest.java > 35026ba > geode-core/src/test/java/org/apache/geode/cache30/CacheXml61DUnitTest.java > ea15c18 > geode-core/src/test/java/org/apache/geode/cache30/CacheXml65DUnitTest.java > a12737b > geode-core/src/test/java/org/apache/geode/cache30/CacheXml66DUnitTest.java > ededb8d > > geode-core/src/test/java/org/apache/geode/internal/JarClassLoaderJUnitTest.java > 31a72c8 > geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java > 21accef > geode-core/src/test/resources/jta/cachejta.xml 9a36ee6 > > geode-core/src/test/resources/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest_single_pool.xml > 92454c4 > > geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-creation-with-eviction.xml > 861bb23 > > geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-creation-without-eviction.xml > f8bdc78 > > geode-core/src/test/resources/org/apache/geode/cache/query/functional/index-recovery-overflow.xml > 4ca5e2f > > geode-core/src/test/resources/org/apache/geode/cache/query/internal/index/cachequeryindex.xml > ebcc0a4 > > geode-core/src/test/resources/org/apache/geode/cache/query/internal/index/cachequeryindexwitherror.xml > caa3cc9 > > geode-core/src/test/resources/org/apache/geode/cache/query/partitioned/PRIndexCreation.xml > 4236a7d > > geode-core/src/test/resources/org/apache/geode/cache30/attributesUnordered.xml > aa8c3f4 > geode-core/src/test/resources/org/apache/geode/cache30/badFloat.xml 883216c > geode-core/src/test/resources/org/apache/geode/cache30/badInt.xml 17f9aa1 > > geode-core/src/test/resources/org/apache/geode/cache30/badKeyConstraintClass.xml > 9aa8cb3 > geode-core/src/test/resources/org/apache/geode/cache30/badScope.xml 0744a72 > > geode-core/src/test/resources/org/apache/geode/cache30/callbackNotDeclarable.xml > fb3cf9c > > geode-core/src/test/resources/org/apache/geode/cache30/callbackWithException.xml > 4a39cc1 > geode-core/src/test/resources/org/apache/geode/cache30/coLocation.xml > 6c23d5f > geode-core/src/test/resources/org/apache/geode/cache30/ewtest.xml 1f40036 > > geode-core/src/test/resources/org/apache/geode/cache30/examples_3_0/example-cache.xml > f7bdc8e > > geode-core/src/test/resources/org/apache/geode/cache30/examples_4_0/example-cache.xml > 4b21e8f > geode-core/src/test/resources/org/apache/geode/cache30/loaderNotLoader.xml > c7fec6f > geode-core/src/test/resources/org/apache/geode/cache30/malformed.xml > 8052ba5 > geode-core/src/test/resources/org/apache/geode/cache30/namedAttributes.xml > 2d3b4a5 > > geode-core/src/test/resources/org/apache/geode/cache30/partitionedRegion.xml > 773cb7b > > geode-core/src/test/resources/org/apache/geode/cache30/partitionedRegion51.xml > 826e500 > geode-core/src/test/resources/org/apache/geode/cache30/sameRootRegion.xml > f34061a > geode-core/src/test/resources/org/apache/geode/cache30/sameSubregion.xml > 26f95bb > > geode-core/src/test/resources/org/apache/geode/cache30/unknownNamedAttributes.xml > 7e570e8 > > geode-core/src/test/resources/org/apache/geode/internal/cache/BackupJUnitTest.cache.xml > 01570f4 > > geode-core/src/test/resources/org/apache/geode/internal/cache/DiskRegCacheXmlJUnitTest.xml > b6818d0 > > geode-core/src/test/resources/org/apache/geode/internal/cache/PartitionRegionCacheExample1.xml > d1b5d11 > > geode-core/src/test/resources/org/apache/geode/internal/cache/PartitionRegionCacheExample2.xml > 4eda72a > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_bytes_threshold.xml > b734ce1 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_dir.xml > 71aba12 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_dir_size.xml > a03139f > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_max_oplog_size.xml > 71dc62f > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_roll_oplogs_value.xml > f3d8594 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_sync_value.xml > 990fa24 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/incorrect_time_interval.xml > a55b690 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/mixed_diskstore_diskdir.xml > 6fcb012 > > geode-core/src/test/resources/org/apache/geode/internal/cache/faultyDiskXMLsForTesting/mixed_diskstore_diskwriteattrs.xml > 6d23a22 > > geode-core/src/test/resources/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.testDTDFallbackWithNonEnglishLocal.cache.xml > 7fb89e4 > geode-core/src/test/resources/org/apache/geode/internal/jta/cachejta.xml > d31a634 > > geode-cq/src/test/resources/org/apache/geode/internal/cache/tier/sockets/durablecq-client-cache.xml > bd84207 > > geode-cq/src/test/resources/org/apache/geode/internal/cache/tier/sockets/durablecq-server-cache.xml > 0f21721 > > geode-spark-connector/geode-spark-connector/src/it/resources/test-regions.xml > 79893d6 > > geode-spark-connector/geode-spark-connector/src/it/resources/test-retrieve-regions.xml > 3023959 > > Diff: https://reviews.apache.org/r/52641/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
