> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote:
> > I also get compilation errors in PulseAppListener and
> > ExceptionHandlingAdvice when I apply this patch, even after refreshing
> > gradle.
>
> Jinmei Liao wrote:
> Hnnn, do a clean and refresh. I am not getting the errors.
No luck. Have you tried doing a clean and then running "gradle uiTest"?
I verified in gradle that this is a problem caused by the removal of the
"force" block in dependency-resolution.gradle.
Before this patch:
```
~/projects/gemfire/open (develop) $ gradle :geode-pulse:dI --dependency
spring-web
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:geode-pulse:dependencyInsight
org.springframework:spring-web:4.2.4.RELEASE (forced)
org.springframework:spring-web:3.0.7.RELEASE -> 4.2.4.RELEASE
--- org.springframework.security:spring-security-web:3.1.7.RELEASE
--- compile
BUILD SUCCESSFUL
```
After this patch:
```
~/projects/gemfire/open (develop) $ gradle :geode-pulse:dI --dependency
spring-web
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:geode-pulse:dependencyInsight
org.springframework:spring-web:3.0.7.RELEASE
--- org.springframework.security:spring-security-web:3.1.7.RELEASE
--- compile
BUILD SUCCESSFUL
```
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151569
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk
> Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
> 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
> a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt
> 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
>
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java
> 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
>
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
> 435b426627deea6c67ecd79bc014ec97774e2ebf
>
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java
> 425f5a5aa76c8219678164ebbb012d1361519bc7
>
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java
> f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
>
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java
> 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html
> f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml
> cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml
> 924dd50f579a6e4e306b94f4a7fd88e87f978add
>
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java
> a77e0cacdcde69f47fbd13c588601072c432ee0d
>
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
> a4f14f89ea739e7390565d652fc5affa6e1326c6
>
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java
> ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
>
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java
> 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml
> c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml
> 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle
> 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties
> 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
