CustomConfigWithCacheIntegrationTest is now fixed. Looks like a formatter
was run on log4j2-custom.xml which introduced a line feed to the longest
line in #247. The currently committed formatters won't introduce line
feeds. Also, I thought the formatters only affected java files, but
apparently that's not true. Sorry about that!

Thanks,
Kirk




On Tue, Oct 4, 2016 at 6:26 PM, Kirk Lund <[email protected]> wrote:

> There were some logging changes that went in today. Not sure why the regex
> is failing to match now but we'll revert the changes tomorrow.
>
> -Kirk
>
> On Tuesday, October 4, 2016, Nabarun Nag <[email protected]> wrote:
>
> >    - The following tests are failing on precheck as well as in IntelliJ
> >    Tests :
> >    -
> >    CustomConfigWithCacheIntegrationTest
> >    <http://test-results-nnagclean.s3-website-us-west-2.amazonaws.com/
> > integrationTest/classes/org.apache.geode.internal.logging.log4j.custom.
> > CustomConfigWithCacheIntegrationTest.html>
> >    . cacheLogWriterMessageShouldMatchCustomConfig
> >    <http://test-results-nnagclean.s3-website-us-west-2.amazonaws.com/
> > integrationTest/classes/org.apache.geode.internal.logging.log4j.custom.
> > CustomConfigWithCacheIntegrationTest.html#cacheLogWriterMessageShouldMat
> > chCustomConfig>
> >    - CustomConfigWithLogServiceIntegrationTest
> >    <http://test-results-nnagclean.s3-website-us-west-2.amazonaws.com/
> > integrationTest/classes/org.apache.geode.internal.logging.log4j.custom.
> > CustomConfigWithLogServiceIntegrationTest.html>
> >    . logEventShouldMatchCustomConfig
> >    <http://test-results-nnagclean.s3-website-us-west-2.amazonaws.com/
> > integrationTest/classes/org.apache.geode.internal.logging.log4j.custom.
> > CustomConfigWithLogServiceIntegrationTest.html#
> > logEventShouldMatchCustomConfig>
> >
> >    With the following error :
> >    -
> >
> >    java.lang.AssertionError:
> >    Expecting:
> >     "CUSTOM: level=DEBUG time=2016/10/04 15:51:11.338 PDT
> >          message=this is a log statement
> >    throwable=
> >    "
> >    to match pattern:
> >     "CUSTOM: level=DEBUG time=.* message=this is a log statement
> >    throwable=
> >    "
> >
>

Reply via email to