-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52307/
-----------------------------------------------------------
Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, and
Kevin Duling.
Bugs: GEODE-1939
https://issues.apache.org/jira/browse/GEODE-1939
Repository: geode
Description
-------
Change SocketCreatorFactoryJUnitTest to IntegrationTest.
Change SocketCreatorFactoryJUnitTest to not extend JSSESocketJUnitTest.
Reorganize imports.
Reformat both classes.
Fix minor concurrency bug in JSSESocketJUnitTest.
Privatize variables and methods to avoid potential spaghetti code.
Remove catching of unexpected exceptions.
Remove system outs.
Move all setup into setup method.
Diffs
-----
geode-core/src/test/java/org/apache/geode/internal/net/JSSESocketJUnitTest.java
4a62ec7
geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorFactoryJUnitTest.java
16e2837
Diff: https://reviews.apache.org/r/52307/diff/
Testing
-------
SocketCreatorFactoryJUnitTest
JSSESocketJUnitTest
precheckin underway
Thanks,
Kirk Lund
