-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51618/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jinmei Liao, John Blum, William
Markito, and Swapnil Bawaskar.
Bugs: GEODE-1836
https://issues.apache.org/jira/browse/GEODE-1836
Repository: geode
Description
-------
GEODE-1836: remove defunct Java 1.6 block for Mac
Geode requires Java 1.8 and does not support Java 1.6. Attempting to
add the 1.6 classes.jar to the classpath for the Attach API results in
breaking the start and status commands in GFSH.
Removal of these script lines allows GFSH to use either the Attach API
in Java 1.8 or an alternative implementation for start and status. The
alternative implementation uses temporary files to communcate with the
other process. If you want to make sure you are using the Attach API
then simply set JAVA_HOME to the location of JDK 1.8.
If you use jenv on Mac, then consider configuring jenv to export
JAVA_HOME by executing:
$ jenv enable-plugin export
Diffs
-----
geode-assembly/src/main/dist/bin/gfsh 935a24e
Diff: https://reviews.apache.org/r/51618/diff/
Testing
-------
manual testing on Mac and Linux
Thanks,
Kirk Lund