> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote:
> > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java,
> > line 189
> > <https://reviews.apache.org/r/51010/diff/1/?file=1471614#file1471614line189>
> >
> > Will this dir and clusterConfigDir get cleaned up after the test is
> > run? Should this use a TemporaryFolder rule or something else?
>
> anilkumar gingade wrote:
> It uses the TemporaryFolder...yes it clears the config dir...Without this
> i was having problem with the second test, where it was loading the cluster
> config from previous test...
>
> Jason Huynh wrote:
> Out of curiosity, how is the TemporaryFolder being used here? Isn't
> there a TemporaryFolder rule that needs to be created and used? This looks
> like it's just doing new File().mkdir()?
I followed the logic from ohter tests...
The file path is obtained from TemporaryFolder Rule, When the test ends the
Rule deletes the dir using the path info.
final String nodeDir = this.temporaryFolder.getRoot().getCanonicalPath()
+ File.separator + vmIndex;
File workingDir = new File(nodeDir);
workingDir.mkdirs();
- anilkumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51010/#review145572
-----------------------------------------------------------
On Aug. 11, 2016, 10:34 p.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51010/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2016, 10:34 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Kirk
> Lund, William Markito, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added test to validate Cluster configuration support for Lucene indexes.
>
> Added a new Rule to create Distributed System with test/custom
> configuration...The "LocatorServerConfigurationRule" makes it easier to
> create a Locator or cluster nodes with required configuration.
>
>
> Diffs
> -----
>
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java
> PRE-CREATION
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51010/diff/
>
>
> Testing
> -------
>
> Run the newly added test.
>
>
> Thanks,
>
> anilkumar gingade
>
>
