Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74340943
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/AbstractCliAroundInterceptor.java
---
@@ -88,7 +88,7 @@ protected Response readYesNo(String message, Response
defaultResponse) {
try {
String userInput = interact(message);
- if (userInput == null || userInput == "") {
+ if (userInput.isEmpty()) {
--- End diff --
Here you need to keep the null check or it could throw an NPE, so:
if (userInput == null || userInput.isEmpty()) {
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---