----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50420/#review143436 -----------------------------------------------------------
Is this supposed to wait until the queue is not null? If so, I don't think it will work, because this code calls getIndexQueue(cache) once and then gets into the awaitility call. If you are just waiting for queue.getSender to be not null, then you should remove the check for queue != null. - Dan Smith On July 25, 2016, 9:42 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50420/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 9:42 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-1671 > https://issues.apache.org/jira/browse/GEODE-1671 > > > Repository: geode > > > Description > ------- > > Need to add Awaitility.waitAtMost > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java > da281ff > > Diff: https://reviews.apache.org/r/50420/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
