----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review134647 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java (line 1077) <https://reviews.apache.org/r/47793/#comment199494> It looks to me like every place we call incrementBucketStats we also now do corresponding updates to dr inVM, onDisk, and BytesOnDisk. How about refactoring this code so that this common pattern is in a single method? You could rename incrementBucketStats to "updateOverflowStats" and add a DiskRegionView parameter. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java (line 1079) <https://reviews.apache.org/r/47793/#comment199495> Why no call of incrementBucketStats here? geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java (line 1772) <https://reviews.apache.org/r/47793/#comment199491> Is anything in this comment still needed? I know that onDisk was NOT already inced. I'm not sure if we need to say anything about the old size. - Darrel Schneider On May 24, 2016, 2:36 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47793/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 2:36 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Ken > Howe. > > > Bugs: GEODE-93 > https://issues.apache.org/jira/browse/GEODE-93 > > > Repository: geode > > > Description > ------- > > - Stats are not updated when a tombstone is scheduled/unscheduled. > - All stats are updated when the data is finally flushed to the disk rather > than doing it eagerly and compensating when on a new operation if the data is > not yet written to disk > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 54ecb0434298ab6af2af8724a33048732735fc7d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > d28496cc6e58cf061ce996d45526f3a0bd3ab10f > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java > 1a3277ca7b9597327e9ce42a61976ad731cc7c1c > > Diff: https://reviews.apache.org/r/47793/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Sai Boorlagadda > >
