----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/#review132444 -----------------------------------------------------------
Ship it! Ship It! geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java (line 83) <https://reviews.apache.org/r/47183/#comment196616> Could you just add a comment indicating this would be the case when using HTTP and not JMX - Jens Deppe On May 10, 2016, 2:51 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47183/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 2:51 p.m.) > > > Review request for geode, Jens Deppe and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java > 1f1f4eb8b1b9a48ebcaf70f1f4bc09de019da2dc > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/JMXShiroAuthenticator.java > 4a4cc285056a6d2f897936f9e4c90a43b90f7fbf > > geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/ShiroPrincipal.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47183/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Jinmei Liao > >
