> On April 27, 2016, 1:46 p.m., Anthony Baker wrote: > > settings.gradle, line 38 > > <https://reviews.apache.org/r/46706/diff/1/?file=1362457#file1362457line38> > > > > If you define this as 'ext.minimumGradleVersion' can we avoid setting > > it both here and in gradle.properties?
I moved the minimumGradleVersion to gradle.properties and removed the one in settings.gradle. Was there a reason to keep it in settings.gradle instead? On April 27, 2016, 1:46 p.m., Jason Huynh wrote: > > After running `gradle wrapper` with the gradleVersion set, the > > `gradle/wrapper/gradle-wrapper.jar` is different, probably because it was > > generated with different gradle version. Should that be updated for > > consistency? > > > > Since this is a build change that will affect everyone, can you send a > > heads up to the dev list? Thanks! Added the gradle-wrapper.jar. I'll send an email before checking in - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46706/#review130784 ----------------------------------------------------------- On April 26, 2016, 11:12 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46706/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 11:12 p.m.) > > > Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, > Mark Bretl, nabarun nag, Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Addresses GEODE-1085 > Addresses GEODE-1261 > > > Diffs > ----- > > BUILDING.md ababe2b > build.gradle 4f79eae > gradle.properties 669baed > gradle/wrapper/gradle-wrapper.properties 7b0d17a > settings.gradle c579dce > > Diff: https://reviews.apache.org/r/46706/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
