----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46636/#review130695 -----------------------------------------------------------
Ship it! I'm not quite sure what this modify_war script is all about, but the rest of the changes look good to me! Maybe someone else who knows more about that can take a look. - Dan Smith On April 25, 2016, 7:57 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46636/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 7:57 p.m.) > > > Review request for geode, anilkumar gingade, Jason Huynh, nabarun nag, and > Dan Smith. > > > Repository: geode > > > Description > ------- > > - Remove cacheserver.sh and gemfire.sh scripts in favor of using gfsh > - Adjust p2p config to always use locators > - Have modify_war reference correct jars > > > Diffs > ----- > > extensions/geode-modules-assembly/build.gradle > 960d9242001df154e23bc8b2bed94a49a980add1 > extensions/geode-modules-assembly/release/conf/cache-client.xml > c36e0ef4bbd4911a2a3aa0f14e738f82c6737c69 > extensions/geode-modules-assembly/release/conf/cache-server.xml > 9dad75f4be93bc68e4dec20dc5a7d458c66494c8 > extensions/geode-modules-assembly/release/scripts/cacheserver.bat > ef7f99fbd79fb00100f8e386eba07507fac0b5f5 > extensions/geode-modules-assembly/release/scripts/cacheserver.sh > 28edc352792c5dc2ffaad21295ebe16e14e59982 > extensions/geode-modules-assembly/release/scripts/gemfire.bat > 6102b88363bbff6626cef3309e0cbd5da41eb816 > extensions/geode-modules-assembly/release/scripts/gemfire.sh > 12956cc7af0890d6128f290f78dd4e8e6fdab82b > extensions/geode-modules-assembly/release/scripts/setenv.properties > fc8918b29d4b040559b79769b2da02d37abdc6e8 > extensions/geode-modules-assembly/release/session/bin/cacheserver.bat > 2935cde7115e0c2565b4d49757c8c25bda1c122e > extensions/geode-modules-assembly/release/session/bin/cacheserver.sh > 2c12b57a98f6f796718e4e7f4d1b2abb0a531c21 > extensions/geode-modules-assembly/release/session/bin/gemfire.bat > a66964cc00e83fe4fd9f073737b5cb5830c2c670 > extensions/geode-modules-assembly/release/session/bin/gemfire.sh > ac11a4dae1ca97c6e1f96733dca787a6a4884849 > extensions/geode-modules-assembly/release/session/bin/modify_war > 9c871047fa228dec1265c0ad5365f56d11d1154b > extensions/geode-modules-assembly/release/session/bin/setenv.properties > fc8918b29d4b040559b79769b2da02d37abdc6e8 > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs-tomcat-7/context-fragment.xml > > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs-tomcat-7/modules.env > 1c14a6c1e1fc0fec05bbef4198b9a5441aa472e7 > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs-tomcat-8/context-fragment.xml > > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs-tomcat-8/modules.env > d2206756d3d0fb5146d4f8e76e3dad0a85e9887b > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs/configuration-prompts.properties > 0ebae9730e9d9fa88959f566bbf996d4f968ef99 > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs/context-fragment.xml > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs/modules.env > 9c4c00a99b4af9f8294b0a0be65588d7727e7e5a > > extensions/geode-modules-assembly/release/tcserver/gemfire-cs/server-fragment.xml > > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p-tomcat-7/context-fragment.xml > > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p-tomcat-7/modules.env > 1c14a6c1e1fc0fec05bbef4198b9a5441aa472e7 > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p-tomcat-8/context-fragment.xml > > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p-tomcat-8/modules.env > d2206756d3d0fb5146d4f8e76e3dad0a85e9887b > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p/configuration-prompts.properties > fdead44e3be7858f4dd982d9323ce74b4d61442c > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p/context-fragment.xml > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p/modules.env > 9c4c00a99b4af9f8294b0a0be65588d7727e7e5a > > extensions/geode-modules-assembly/release/tcserver/gemfire-p2p/server-fragment.xml > > extensions/geode-modules-session/build.gradle > e301a6a2372d5b9f5ae0da22b57c8e431c4e09ac > > extensions/geode-modules/src/main/java/com/gemstone/gemfire/modules/util/Banner.java > dbe8e05eef832d3538baa7c6c9a142b7f9216fbb > geode-core/build.gradle 2206018efeebb9c0105834dd09760592b7032873 > gradle/dependency-versions.properties > f89f2818f283369bc955b0129a58c9014f677a92 > > Diff: https://reviews.apache.org/r/46636/diff/ > > > Testing > ------- > > Working through the docs with Karen and ensuring that the instructions line > up with the code/configuration. > > > Thanks, > > Jens Deppe > >
