----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46655/#review130505 -----------------------------------------------------------
Fix it, then Ship it! After addressing this issue and doing the test ship it! geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java (line 64) <https://reviews.apache.org/r/46655/#comment194270> I think the SHORT_WAIT_MS should be 1. I don't see a reason why we would want to extend it. Could you alter the test to fail because it never configures the short expiration and run it once and make sure it fails in a reasonable way (with you 1 minute timeout) instead of it being declared hung? - Darrel Schneider On April 25, 2016, 12:12 p.m., Scott Jewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46655/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 12:12 p.m.) > > > Review request for geode. > > > Repository: geode > > > Description > ------- > > GEODE-1288: Refactor test and extend wait times > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java > a34b9af070f5567d8aa90b7af63ea39378e04ca2 > > Diff: https://reviews.apache.org/r/46655/diff/ > > > Testing > ------- > > > Thanks, > > Scott Jewell > >
