-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46474/#review129974
-----------------------------------------------------------



We'll need to think a little bit about how to create the gradle build files for 
these things. I see that you've added geode-examples as a subproject of the 
main geode build. But the individual examples should probably *not* be 
subprojects, they should be standalone projects that can be copied elsewhere. 
We can maybe invoke their builds with something the 
[gradlebuild|https://docs.gradle.org/current/dsl/org.gradle.api.tasks.GradleBuild.html]
 task or something. Maybe you could provide a starter example project do 
demonstate how the layout is supposed to work?


geode-examples/gradle.properties (line 1)
<https://reviews.apache.org/r/46474/#comment193554>

    I don't think this the correct comment syntax for properties files. Should 
be lines  starting with #. See gradle.properties in the root directory.


- Dan Smith


On April 21, 2016, 5:13 a.m., William Markito wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46474/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 5:13 a.m.)
> 
> 
> Review request for geode, Anthony Baker and Dan Smith.
> 
> 
> Bugs: GEODE-33
>     https://issues.apache.org/jira/browse/GEODE-33
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Initial structure for geode-examples with list of examples
> 
> 
> Diffs
> -----
> 
>   geode-examples/README.md PRE-CREATION 
>   geode-examples/build.gradle PRE-CREATION 
>   geode-examples/gradle.properties PRE-CREATION 
>   settings.gradle c579dce 
> 
> Diff: https://reviews.apache.org/r/46474/diff/
> 
> 
> Testing
> -------
> 
> Build with latest snapshot
> Build with specific geode version from command line (gradle build 
> -PgeodeVersion=X.Y.Z)
> 
> 
> Thanks,
> 
> William Markito
> 
>

Reply via email to