----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46468/#review129911 -----------------------------------------------------------
Ship it! I don't think that changes to existing tests really need a review. If the test passes and the assertions haven't been significantly changed it's okay to check in changes like this without a review. - Bruce Schuchardt On April 21, 2016, 1:44 a.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46468/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 1:44 a.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > GEODE-1227: > - Replaced all port selections for server with '0' instead of getting the > port from the AvailablePortHelper. > - Some refactoring introducing Lambdas. > - Some refactoring replacing Wait.wait with Awaitility. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java > 4d651a2c1069ca7d00d9f8fbd304cc9a72c9d30a > > geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ClientCommandsDUnitTest.java > bc80563d7e4307c640d3a001e8078552b68cd55c > > Diff: https://reviews.apache.org/r/46468/diff/ > > > Testing > ------- > > precheckin queued > > > Thanks, > > Udo Kohlmeyer > >
