----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39012/#review113521 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArray.java (line 210) <https://reviews.apache.org/r/39012/#comment174265> The change of order will remove the ArrayIndexOutOfBorderException. However, I am not sure about the side effect. It is possible that after executing "--size", but just before elementData is reassigned, the second thread picks up the new size, but the array is not updated yet. Will this be a problem for the second thread? If not, then that's fine. - Jianxia Chen On Oct. 5, 2015, 8 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39012/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 8 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, > and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > It was possible that the backing array was modified but another thread was > using a size that was larger than the current array. Modified the order of > execution to lower the size first before modifying the backing array. > > This is a ported change. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArray.java > e0c17cf > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/IndexElemArrayJUnitTest.java > d5285c4 > > Diff: https://reviews.apache.org/r/39012/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
