You don't need to push commits to close PRs (at least not in GitHub; not sure how Apace works).
On Fri, Jan 8, 2016 at 9:14 AM, Kirk Lund <[email protected]> wrote: > Since #36 and #38 were already merged into develop via #42, should I closed > them with two separate empty commits or is there a way to combine them? > > git commit --allow-empty -m "Closes #36 *Already fixed*" > git commit --allow-empty -m "Closes #38 *Already fixed*" > > -Kirk > > > On Thu, Jan 7, 2016 at 5:13 PM, Dave Barnes <[email protected]> wrote: > > > Update index.html > > #38 opened on Nov 18, 2015 by GregChase > > PR #38 should be closed. I merged #38 with #36 into a later pull request, > > #42, which was committed as part of the web page update. > > > > > > On Thu, Jan 7, 2016 at 4:48 PM, Dan Smith <[email protected]> wrote: > > > > > #29 caused test failures. I commented on that and I was hoping the > author > > > would pick that up and fix the failures, otherwise we may want to fix > > those > > > and merge that at some point. > > > > > > -Dan > > > > > > On Thu, Jan 7, 2016 at 4:41 PM, Kirk Lund <[email protected]> wrote: > > > > > > > We have 6 pull requests that have been open for quite a while. Is > > someone > > > > already working on each of these? What's the status on them? > > > > > > > > https://github.com/apache/incubator-geode/pulls > > > > > > > > Enabling direct reporting on Geode's website > > > > #66 opened 10 days ago by rvs > > > > > > > > GEODE-341/ GEODE-628: Refactor Java packages to reflect Apache > > > organization > > > > /Rename container folder to "geode-jvsd" > > > > #49 opened on Dec 8, 2015 by jujoramos > > > > > > > > Verified preceding content merges, fixed a couple of typos. > > > > #47 opened on Dec 4, 2015 by davebarnes97 > > > > > > > > Addresses the documentation component of GEODE-268, adding > > explanatio... > > > > #43 opened on Nov 23, 2015 by davebarnes97 > > > > > > > > Update index.html > > > > #38 opened on Nov 18, 2015 by GregChase > > > > > > > > GEODE-252] Remove deprecated PartitionAttributes methods > > > > #29 opened on Nov 5, 2015 by shroman > > > > > > > > > > -- -John 503-504-8657 john.blum10101 (skype)
