----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42045/ -----------------------------------------------------------
(Updated Jan. 8, 2016, 12:35 a.m.) Review request for geode, Ashvin A and Dan Smith. Repository: geode Description ------- Improper clean up of a test directory causes a DiskAccessException when creating a region. That also causes the cache to close asynchronously, raising a CacheClosedException during test tearDown. Minor refactoring: * Moved putSuccessful and exceptionOccurred inside Puts * Remove unnecessary thread creation for Puts in DiskRegionJUnitTest Diffs ----- gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionJUnitTest.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/DiskRegionTestingBase.java PRE-CREATION Diff: https://reviews.apache.org/r/42045/diff/ Testing ------- ./gradlew gemfire-core:integrationTest -DintegrationTest.single=DiskRegionJUnit Passes The bug was reproduced by adding another test that loop through multiple calls to testSingleDirectorySizeViolation() as suggested at https://cwiki.apache.org/confluence/display/GEODE/Tips+and+Tricks+for+fixing+DUnit+test+failures. That also passed after this fix. Thanks, Shreedhar Hardikar
