----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38971/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and Lynn Gallinat. Repository: geode Description ------- GMSHealthMonitor was only accepting a health-check response to see if a member was alive or not. This change-set modifies it to allow any message from the suspect to prove that the suspect is alive. This reduced the amount of suspect processing going on quite a bit, and made it less likely to incorrectly oust a busy member. GMSMembershipManager was not throwing an exception when distribution was attempted but the manager was shutting down. This caused large inconsistencies between clients and servers in client/server HA testing. TCPServer's message to determine the locator's version was using a 2-minute timeout, totally ignoring the timeout passed to it. It now pays attention to the requested timeout. A number of tests were using Java assertions instead of JUnit Assert. I changed all of these in our recently added tests to use the JUnit assertions in case the JUnit jvm doesn't have assertions enabled. Diffs ----- build.gradle d7b496591ecd4129f43e9f5fd147babc33a46b15 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 382850a2d0d560daad18184754fba88c6215f874 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java 407ed9bafdc0f58a8b53a68862d08b91ee45ece4 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 4ea3a10cddcf073505775e4edd5fea2a027f0028 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 159b1ca769d392f10e10df52518f0b896e3a3dbf gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java 6720f64cc0fe57229bcc804f3f97ecab8025b79d gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java 8b68b18c883e5f4bb2049c0789ccfe22b10b4900 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java 9ceff7c1a28f84d71ddff312b775c4e727836d6b gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/StatRecorderJUnitTest.java 38010740dcb863f3a2fcfb3e5297d145e7fe07ab Diff: https://reviews.apache.org/r/38971/diff/ Testing ------- precheckin, network-down integration testing, HA integration testing Thanks, Bruce Schuchardt
