----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38572/#review100324 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java (line 1587) <https://reviews.apache.org/r/38572/#comment157507> Change "boolean existingSystemDisconnected = false;" to "boolean existingSystemDisconnected;" since on the very next line you initialize it. gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java (line 1619) <https://reviews.apache.org/r/38572/#comment157509> Change this loop from "do..while" to "while". Then you can get rid of the nested "if !existingSystems.isEmpty()" line (on line 1590). - Darrel Schneider On Sept. 23, 2015, 4:51 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38572/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 4:51 p.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: geode-329 > https://issues.apache.org/jira/browse/geode-329 > > > Repository: geode > > > Description > ------- > > There's a race conditition that 2 DS will be created when the current DS is > disconnecting. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java > b7b2cd8 > > Diff: https://reviews.apache.org/r/38572/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > xiaojian zhou > >
