----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37098/#review94241 -----------------------------------------------------------
Ship it! Ship It! - Swapnil Bawaskar On Aug. 4, 2015, 9:31 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37098/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 9:31 p.m.) > > > Review request for geode and Swapnil Bawaskar. > > > Bugs: GEODE-186 > https://issues.apache.org/jira/browse/GEODE-186 > > > Repository: geode > > > Description > ------- > > testSuspendTimeout now schedules the expiration to happen after 1 ms (instead > of 1 minute). > Most sleeps not needed since the operation it was waiting for is synchronous. > For the sleeps that were needed, they now use a wait. > I think the only sleep that was needed was on a client since the server will > push events to it async. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java > 88714b02385a9282d57eb6be9bddb2175b7b130d > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java > 3ce8cec00738e5a2ac813c42c0c4e4916e0f6451 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java > 0daaafb6b11edf07f5e3a38e3f23e701c230dc62 > > Diff: https://reviews.apache.org/r/37098/diff/ > > > Testing > ------- > > ran all RemoteTransactionDUnitTest subclasses. > > > Thanks, > > Darrel Schneider > >